solstice-pp

commit c2d8c758327f17b3599819bf442ac61a8b9a8eac
parent 7a8b3c40dc169e9229284411adf99edb73847ac5
Author: Christophe Coustet <christophe.coustet@meso-star.com>
Date:   Tue, 23 Jun 2026 17:04:52 +0200

Fix warnings

The improved flags show new warnings that needed to be fixed

Diffstat:
M
src/solmaps.c
 | 
3
++-
M
src/solpaths.c
 | 
2
+-
M
src/solpp.c
 | 
8
++++----
M
src/solpp.h
 | 
2
+-
M
src/solppraw.c
 | 
2
+-

5 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/solmaps.c b/src/solmaps.c
@@ -48,7 +48,8 @@ main(int argc, char** argv)
       CHK(rcv_name = strdup(line)); /* Duplicate the line of the receiver name */
 
       /* Create the name of the destination file */
-      CHK(snprintf(s, sizeof(s), "%g-%g-%s.vtk", azim, elev, rcv_name) < sizeof(s));
+      CHK(snprintf(s, sizeof(s), "%g-%g-%s.vtk", azim, elev, rcv_name)
+          < (long)sizeof(s));
       printf("Writing `%s'\n", s);
       CHK(output = fopen(s, "w"));
 
diff --git a/src/solpaths.c b/src/solpaths.c
@@ -36,7 +36,7 @@ main(int argc, char** argv)
       fprintf(output, "%s\n", line);
     } else {
       CHK(sscanf(line+19, "%lf %lf (%*f %*f %*f)", &azim, &elev) == 2);
-      CHK(snprintf(s, sizeof(s), "%g-%g-paths.vtk", azim, elev) < sizeof(s));
+      CHK(snprintf(s, sizeof(s), "%g-%g-paths.vtk", azim, elev) < (long)sizeof(s));
       if(output) fclose(output);
       printf("Writing `%s'\n", s);
       CHK(output = fopen(s, "w"));
diff --git a/src/solpp.c b/src/solpp.c
@@ -230,7 +230,7 @@ main(int argc, char** argv)
     CHK(!strncmp(line, "#--- Sun direction:", 19));
     CHK(sscanf(line+19, "%lf %lf (%*f %*f %*f)", &simul.azimuth, &simul.elevation)==2);
     CHK(snprintf(prefix, sizeof(prefix), "%g-%g-",
-      simul.azimuth, simul.elevation) < sizeof(prefix));
+      simul.azimuth, simul.elevation) < (long)sizeof(prefix));
     read_simulation(&simul, input);
 
     while((line = read_line(&buf, geom)) && strncmp(line, "#--- Sun", 8)) {
@@ -302,7 +302,7 @@ main(int argc, char** argv)
     if(rcv) { BUF_PUSH(msh_rcv.ncells, ntris_grp); }
 
     CHK(snprintf(filename, sizeof(filename),
-      "%sprimaries.vtk", prefix) < sizeof(prefix));
+      "%sprimaries.vtk", prefix) < (long)sizeof(prefix));
     printf("Writing `%s'\n", filename);
     CHK(output = fopen(filename, "w"));
     mesh_write_vtk(output, &msh_prim);
@@ -310,7 +310,7 @@ main(int argc, char** argv)
     fclose(output);
 
     CHK(snprintf(filename, sizeof(filename),
-      "%sreceivers.vtk", prefix) < sizeof(prefix));
+      "%sreceivers.vtk", prefix) < (long)sizeof(prefix));
     printf("Writing `%s'\n", filename);
     CHK(output = fopen(filename, "w"));
     mesh_write_vtk(output, &msh_rcv);
@@ -318,7 +318,7 @@ main(int argc, char** argv)
     fclose(output);
 
     CHK(snprintf(filename, sizeof(filename),
-      "%smiscellaneous.obj", prefix) < sizeof(prefix));
+      "%smiscellaneous.obj", prefix) < (long)sizeof(prefix));
     printf("Writing `%s'\n", filename);
     CHK(output = fopen(filename, "w"));
     mesh_write_obj(output, &msh_misc);
diff --git a/src/solpp.h b/src/solpp.h
@@ -142,7 +142,7 @@ struct rcvXprim {
   size_t prim_id;
 };
 static inline void rcvXprim_init(struct rcvXprim* r) {memset(r, 0, sizeof(*r));}
-static inline void rcvXprim_release(struct rcvXprim* r) { /*Do nothing*/ }
+static inline void rcvXprim_release(struct rcvXprim* r) { (void)r; /*Do nothing*/ }
 
 /*******************************************************************************
  * Overall estimations of a simulation
diff --git a/src/solppraw.c b/src/solppraw.c
@@ -147,7 +147,7 @@ main(int argc, char** argv)
     CHK(sscanf(line+19, "%lf %lf (%*f %*f %*f)",
       &simul.azimuth, &simul.elevation)==2);
     CHK(snprintf(s, sizeof(s), "%g-%g-raw-results.txt",
-      simul.azimuth, simul.elevation) < sizeof(s));
+      simul.azimuth, simul.elevation) < (long)sizeof(s));
     read_simulation(&simul, input);
 
     printf("Writing `%s'\n", s);